attest: remove flavors #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
changed the title
TheButlah
changed the title
TheButlah
changed the title
TheButlah
force-pushed
the
thebutlah/remove-flavors
branch
from
524aad7
to
6701c81
Compare
TheButlah
force-pushed
the
thebutlah/remove-flavors
branch
from
6701c81
to
4ff034c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flavors are problematic because they double compile times and cause us to have to produce and distribute prod and stage versions of every binary. However, most of the binaries are actually identical between these two versions.
Instead of doing compile time feature flags, we should simply detect this stuff with environment variables at runtime. In the absence of an env var, the code should fall back to prod behavior.
As a consequence, this also removes the
_prod_part of the artifact names.