Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wildcard parameter is extracted properly #35

Merged
merged 1 commit into from
Oct 10, 2014

Conversation

saml
Copy link
Contributor

@saml saml commented Oct 9, 2014

If path is <basePath>/{url*}/foobar, regex generated is <basePath>/[^/]*/foobar when it should be <basePath>/.*/foobar due to wildcard.

@simonlopez
Copy link
Contributor

Could you provide some unit tests before we could merge?

@saml
Copy link
Contributor Author

saml commented Oct 10, 2014

Added test.

simonlopez added a commit that referenced this pull request Oct 10, 2014
wildcard parameter is extracted properly
@simonlopez simonlopez merged commit e42f5cb into worldline:master Oct 10, 2014
@saml saml deleted the patch-1 branch October 10, 2014 15:10
@saml
Copy link
Contributor Author

saml commented Oct 10, 2014

When is new release scheduled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants