Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge: move initial guardian set fetching to pkg/ethereum/watcher.go #46

Closed
wants to merge 3 commits into from

Commits on Oct 21, 2020

  1. bridge: move initial guardian set fetching to pkg/ethereum/watcher.go

    This removes the special case in the processor. The initial guardian set
    is now treated like a regular guardian set update, and the devnet
    update check is executed on every update.
    
    Fixes an edge case where processing a guardian set update would fail
    with a spurious `abi: attempting to unmarshall an empty string while arguments are expected`
    error, leaving the node in a bad state since restarting ethwatch
    wouldn't cause the guardian set to be re-fetched.
    
    [ghstack-poisoned]
    Leo committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    870a734 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Update on "bridge: move initial guardian set fetching to pkg/ethereum…

    …/watcher.go"
    
    This removes the special case in the processor. The initial guardian set
    is now treated like a regular guardian set update, and the devnet
    update check is executed on every update.
    
    Fixes an edge case where processing a guardian set update would fail
    with a spurious `abi: attempting to unmarshall an empty string while arguments are expected`
    error, leaving the node in a bad state since restarting ethwatch
    wouldn't cause the guardian set to be re-fetched.
    
    [ghstack-poisoned]
    Leo committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    3117f59 View commit details
    Browse the repository at this point in the history
  2. Update on "bridge: move initial guardian set fetching to pkg/ethereum…

    …/watcher.go"
    
    This removes the special case in the processor. The initial guardian set
    is now treated like a regular guardian set update, and the devnet
    update check is executed on every update.
    
    Fixes an edge case where processing a guardian set update would fail
    with a spurious `abi: attempting to unmarshall an empty string while arguments are expected`
    error, leaving the node in a bad state since restarting ethwatch
    wouldn't cause the guardian set to be re-fetched.
    
    [ghstack-poisoned]
    Leo committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    e406608 View commit details
    Browse the repository at this point in the history