Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing version 0.5.0 #9

Merged
merged 1 commit into from
Sep 8, 2019
Merged

Introducing version 0.5.0 #9

merged 1 commit into from
Sep 8, 2019

Conversation

pkhabazi
Copy link
Collaborator

@pkhabazi pkhabazi commented Sep 8, 2019

Summary of the Pull Request

Cleaned up code and optimized the functions, also introducing new functions:

  • Get-AzSentinelAlertRule - allows you to get the current configuration
  • Import-AzSentinelAlertRule - Imports the config from json or yaml
  • New-AzSentinelAlertRule - creates alert rules from cmdlet
  • Remove-AzSentinelAlertRule - allows you to remove Alert rules

References

#5
#6
#7

PR Checklist

By submitting this pull request, I confirm the following:

please fill any appropriate checkboxes, e.g: [X]


Detailed Description of the Pull Request / Additional comments

A detailed description, screenshots (if necessary), as well as links to any relevant issues

Validation Steps Performed

A detailed description of thew validation steps

How does this PR accomplish the above

A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix

What documentation changes (if any) are needed to support this PR

A detailed list of any necessary changes


  • You must follow the template instructions. Failure to do so will result in your pull request being closed.

@pkhabazi pkhabazi added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 8, 2019
@pkhabazi pkhabazi self-assigned this Sep 8, 2019
@pkhabazi pkhabazi force-pushed the UpdatingModule branch 2 times, most recently from 41da51c to c0e99e4 Compare September 8, 2019 12:08
@pkhabazi pkhabazi requested review from MauRiEEZZZ and removed request for bgelens September 8, 2019 21:11
@MauRiEEZZZ
Copy link

Get-AzSentinelAlertRule.md

Example 1 2 3
descriptions of the examples aren't updated from the copy/paste action
To me -WhatIf and -Confirm are obsolete for this function, what do you think?

When using Get-AzSentinelAlertRule I prefer to have the DisplayName on top.
While using Format-Table the DisplayName will be the first Collumn.

While executing the function I see some flickering on the top of the screen.
Probably of the webrequest invocation. Have I seen this in the earlier version?

The Synopsis, I am not sure what to expect there it isen't consequent, it says often Manage Azure Sentinel Alert Rules.

@MauRiEEZZZ
Copy link

Remove-AzSentinelAlertRule
I was thinking I could do the following Example, but instead I received errors, Maybe I am using it wrong.
image
I did see RuleName accepts pipeline input in the helpfiles and it says (ByValue).
Perhaps I am doing this wrong, I just expected it work like in my example.
I have seen a similar way of working in other modules.

Confirm works perfect, great choice of options.

I do think it always should prompt for deletion and -Force will ovveride this behaviour.

@MauRiEEZZZ
Copy link

New-AzSentinelAlertRule
I tried the following, what is wrong with my value for -QueryFrequency ??
image

@pkhabazi
Copy link
Collaborator Author

pkhabazi commented Sep 8, 2019

New-AzSentinelAlertRule
I tried the following, what is wrong with my value for -QueryFrequency ??
image

you don't need to add "PT" for time, this is dono by the class

@pkhabazi
Copy link
Collaborator Author

pkhabazi commented Sep 8, 2019

Remove-AzSentinelAlertRule
I was thinking I could do the following Example, but instead I received errors, Maybe I am using it wrong.
image
I did see RuleName accepts pipeline input in the helpfiles and it says (ByValue).
Perhaps I am doing this wrong, I just expected it work like in my example.
I have seen a similar way of working in other modules.

Confirm works perfect, great choice of options.

I do think it always should prompt for deletion and -Force will ovveride this behaviour.

this is a good one, I think we need to create a new issue for this as a feature request

@pkhabazi
Copy link
Collaborator Author

pkhabazi commented Sep 8, 2019

Get-AzSentinelAlertRule.md

Example 1 2 3
descriptions of the examples aren't updated from the copy/paste action
To me -WhatIf and -Confirm are obsolete for this function, what do you think?

When using Get-AzSentinelAlertRule I prefer to have the DisplayName on top.
While using Format-Table the DisplayName will be the first Collumn.

While executing the function I see some flickering on the top of the screen.
Probably of the webrequest invocation. Have I seen this in the earlier version?

The Synopsis, I am not sure what to expect there it isen't consequent, it says often Manage Azure Sentinel Alert Rules.

updated documentation

@pkhabazi pkhabazi merged commit da4c18c into master Sep 8, 2019
@pkhabazi pkhabazi deleted the UpdatingModule branch September 10, 2019 16:09
pkhabazi added a commit that referenced this pull request Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Get-AzSentinelAlertRule and maybe remove?
2 participants