Lberg/doc ref systems #66
Conversation
lucabergamini
requested review from
laky,
pondruska,
yawei-ye and
stefaniespeichert
Do not forget to approve the PR when you think it looks good to you xD |
- satellite ref system description - semantic ref system description - links for ref systems (ECEF and ENU)
lucabergamini
dismissed stale reviews from oliver-scheel and yawei-ye
via
0730226
| draw_trajectory(im, positions_pixels, data["target_yaws"], TARGET_POINTS_COLOR) | ||
| ``` | ||
|
|
||
| ## Satellite Coordinate System |
There was a problem hiding this comment.
I'd clarify this section a bit, as three coordinate systems are used (image, world, ECEF), and the reader might get a bit confused in my opinion:
If zarr contains world coordinates, can we not directly go from world to image? Why do we need ECEF, which data uses ECEF?
There was a problem hiding this comment.
ECEF is a "safe" space, in the sense that everything can be converted into ECEF (semantic, satellite, world). Both semantic and satellite have matrices that go from their space into ECEF, but not to world (we build them at runtime)
There was a problem hiding this comment.
I'll try to clarify it a bit more
There was a problem hiding this comment.
@lucabergamini @oliver-scheel I added the origin of the world coordinate system with google map link.
|
Great, I'll merge this now. As we're changing the dataset structure on the disk something will change also here, but I'll start a PR later today (hopefully) to include the change-log. Thanks everyone! |
PR to add a doc section about the different reference systems in L5Kit