GHA/reusable-testing: start running the tests against PHP 8.3 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.3 is nearing the RC phase. As WP-CLI is used in the build processes of plenty of other WP packages, I believe it would be beneficial to start supporting PHP 8.3 officially sooner rather than later. This commit adds PHP 8.3 to the build matrix to start running the tests against PHP 8.3. Note: I'm not sure how to test the workflow as things are, so I hope I've done it correctly. I've also opened a PR in the Behat repo to start running their tests against PHP 8.3 (Behat/Behat 1440) and their build currently passes, so I expect that the tooling used should all work on PHP 8.3. Having said that, whether PHP 8.3 can be supported without any fixes will need to be evaluated individually for each WP-CLI repo, so for now, I've added a `continue-on-error` for PHP 8.3 to be on the safe side.
swissspidy
approved these changes
Aug 28, 2023
|
Thanks @jrfnl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.3 is nearing the RC phase. As WP-CLI is used in the build processes of plenty of other WP packages, I believe it would be beneficial to start supporting PHP 8.3 officially sooner rather than later.
This commit adds PHP 8.3 to the build matrix to start running the tests against PHP 8.3.
Note: I'm not sure how to test the workflow as things are, so I hope I've done it correctly. I've also opened a PR in the Behat repo to start running their tests against PHP 8.3 (Behat/Behat#1440) and their build currently passes, so I expect that the tooling used should all work on PHP 8.3.
Having said that, whether PHP 8.3 can be supported without any fixes will need to be evaluated individually for each WP-CLI repo, so for now, I've added a
continue-on-errorfor PHP 8.3 to be on the safe side.