Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boolean value of config variables to literal string when showing to the user #182

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

imrraaj
Copy link

@imrraaj imrraaj commented Jun 18, 2024

This pull request fixes following issue

I refactored the code to return the string representation of a boolean value (i.e., 'true' or 'false'), which is easier to display to the user. Previously, when the variable's value was true, it would render as '1', and blank when false. Using strings allows us to provide clearer guidance to the user regarding which value is true and which is false.

@imrraaj imrraaj marked this pull request as ready for review June 19, 2024 09:46
@imrraaj imrraaj requested a review from a team as a code owner June 19, 2024 09:46
@imrraaj
Copy link
Author

imrraaj commented Jul 2, 2024

Can I get a review on this PR? @danielbachhuber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show literal "true"/"false" when reading boolean values instead of an empty string
1 participant