Fix --format in core check-update command
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernilambar
force-pushed
the
250-check-update-format
branch
from
82ee51a
to
2ec2056
Compare
ernilambar
force-pushed
the
250-check-update-format
branch
from
2ec2056
to
429e2e5
Compare
|
No idea why test is failing at PHP 5.6 😔 |
features/core-check-update.feature
Outdated
|
|
||
| $obj = new stdClass; | ||
| $obj->updates = []; | ||
| $obj->last_checked = '1709881133'; |
There was a problem hiding this comment.
Can we compute this so it's always a far-future date?
schlessera
approved these changes
Mar 14, 2024
|
Thanks, @ernilambar ! |
schlessera
changed the title
--format in core check-update command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250