Skip to content

Fix --format in core check-update command #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Fix --format in core check-update command #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
429e2e5
Fix format in core check update command
ernilambar Mar 8, 2024
5b50f5a
Make last check date to very far future in core check update test
ernilambar Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions features/core-check-update.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,37 @@ Feature: Check for more recent versions
"""
1
"""

Scenario: Check output of check update in different formats (no updates available)
Given a WP install
And a setup.php file:
"""
<?php
global $wp_version;

$obj = new stdClass;
$obj->updates = [];
$obj->last_checked = strtotime( '1 January 2099' );
$obj->version_checked = $wp_version;
$obj->translations = [];
set_site_transient( 'update_core', $obj );
"""
And I run `wp eval-file setup.php`

When I run `wp core check-update`
Then STDOUT should be:
"""
Success: WordPress is at the latest version.
"""

When I run `wp core check-update --format=json`
Then STDOUT should be:
"""
[]
"""

When I run `wp core check-update --format=yaml`
Then STDOUT should be:
"""
---
"""
6 changes: 4 additions & 2 deletions src/Core_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,16 +77,18 @@ class Core_Command extends WP_CLI_Command {
* @subcommand check-update
*/
public function check_update( $_, $assoc_args ) {
$format = Utils\get_flag_value( $assoc_args, 'format', 'table' );

$updates = $this->get_updates( $assoc_args );
if ( $updates ) {

if ( $updates || 'table' !== $format ) {
$updates = array_reverse( $updates );
$formatter = new Formatter(
$assoc_args,
[ 'version', 'update_type', 'package_url' ]
);
$formatter->display_items( $updates );
} elseif ( empty( $assoc_args['format'] ) || 'table' === $assoc_args['format'] ) {
} else {
WP_CLI::success( 'WordPress is at the latest version.' );
}
}
Expand Down