-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CS checking based on the WP_CLI_CS
ruleset
#46
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
eed05d9
PHPCS: Add new ruleset to the project
thrijith 1114e4d
PHPCS: Add prefix to global variables
thrijith 5ac098d
PHPCS: Fix up errors in src/Cron_Command.php
thrijith c99bed3
PHPCS: Fix up errors in src/Cron_Event_Command.php
thrijith 3714f2c
PHPCS: Fix up errors in src/Cron_Schedule_Command.php
thrijith c1a62ff
PHPCS: Refactor usage of translatable functions
thrijith 6aab973
PHPCS: Update variable name
thrijith 4358df7
PHPCS: Update ruleset
thrijith d925ac2
PHPCS: Add comment for whitelist,
thrijith 42346d5
PHPCS: Use version 2.1 and above for wp-cli-test
thrijith 7c9aa0b
PHPCS: Update ruleset and remove previously excluded directories
thrijith 3f60bce
PHPCS: Remove uncessary whitelist comment
thrijith 9f7e116
PHPCS: Move whitelist comment to preceding lines
thrijith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,8 @@ | |
.travis.yml | ||
behat.yml | ||
circle.yml | ||
phpcs.xml.dist | ||
phpunit.xml.dist | ||
bin/ | ||
features/ | ||
utils/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,6 @@ vendor/ | |
*.tar.gz | ||
composer.lock | ||
*.log | ||
phpunit.xml | ||
phpcs.xml | ||
.phpcs.xml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
<?xml version="1.0"?> | ||
<ruleset name="WP-CLI-cron"> | ||
<description>Custom ruleset for WP-CLI cron-command</description> | ||
|
||
<!-- | ||
############################################################################# | ||
COMMAND LINE ARGUMENTS | ||
For help understanding this file: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Annotated-ruleset.xml | ||
For help using PHPCS: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Usage | ||
############################################################################# | ||
--> | ||
|
||
<!-- What to scan. --> | ||
<file>.</file> | ||
|
||
<!-- Ignoring select files/folders. | ||
https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignoring-files-and-folders --> | ||
<exclude-pattern>*/node_modules/*</exclude-pattern> | ||
<exclude-pattern>*/vendor/*</exclude-pattern> | ||
|
||
<!-- Show progress. --> | ||
<arg value="p"/> | ||
|
||
<!-- Strip the filepaths down to the relevant bit. --> | ||
<arg name="basepath" value="./"/> | ||
|
||
<!-- Check up to 8 files simultaneously. --> | ||
<arg name="parallel" value="8"/> | ||
|
||
<!-- | ||
############################################################################# | ||
USE THE WPCliCS RULESET | ||
############################################################################# | ||
--> | ||
|
||
<rule ref="WPCliCS"/> | ||
|
||
<!-- | ||
############################################################################# | ||
PROJECT SPECIFIC CONFIGURATION FOR SNIFFS | ||
############################################################################# | ||
--> | ||
|
||
<!-- For help understanding the `testVersion` configuration setting: | ||
https://github.com/PHPCompatibility/PHPCompatibility#sniffing-your-code-for-compatibility-with-specific-php-versions --> | ||
<config name="testVersion" value="5.4-"/> | ||
|
||
<!-- Verify that everything in the global namespace is either namespaced or prefixed. | ||
See: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#naming-conventions-prefix-everything-in-the-global-namespace --> | ||
<rule ref="WordPress.NamingConventions.PrefixAllGlobals"> | ||
<properties> | ||
<property name="prefixes" type="array"> | ||
<element value="WP_CLI\Cron"/><!-- Namespaces. --> | ||
<element value="wpcli_cron"/><!-- Global variables and such. --> | ||
</property> | ||
</properties> | ||
</rule> | ||
|
||
<!-- Exclude existing classes from the prefix rule as it would break BC to prefix them now. --> | ||
<rule ref="WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedClassFound"> | ||
<exclude-pattern>*/src/Cron_(Event_|Schedule_)?Command\.php$</exclude-pattern> | ||
</rule> | ||
|
||
</ruleset> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something looks wrong here, two comments instead of just the one.
Suggestion: