-
Notifications
You must be signed in to change notification settings - Fork 80
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin update
does not fail on bad file permissions
#90
Comments
It appears that there are two main issues here:
The function that outputs the result of the command is To replicate this bug:
I propose that when this command is run and encounters permissions errors, that the new_version rendered for the plugin in the table should be the same as the old version, the "Error" status should remain, and instead of "Success: Plugin already updated." we should see "Error: Plugin update failed." Perhaps WP-CLI should also highlight any failed updates? |
Fixed issue wp-cli/wp-cli#3761 in the parent repo was similar. It was for installing a plugin, this one is for updating a plugin (or all plugins). |
plugin update
does not fail on bad file permissions
Fixed via #143 |
Running
wp plugin update --all
does not fail with bad file permissions:For reference:
The text was updated successfully, but these errors were encountered: