-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strings from WordPress core's components.js are not extracted #297
Comments
I was just about to open an issue on the Peast repo, but you beat me to it :-) Not sure what would be a good workaround for the meantime. Maybe some build config to retain the leading zeros? |
Now that the upstream bug has been fixed, I think all that‘s needed is updating the dependency here / in the final bundle |
@swissspidy For now there is not release of Peast with this fix. |
@swissspidy Peast library was updated to version with fixes for this issue in #299. |
Bug Report
Describe the current, buggy behavior
The translation project for WordPress 5.9 is missing some strings, particularly from
components.js
.Describe how other contributors can replicate this bug
wp i18n make-pot . --ignore-domain
(orphp -d memory_limit=1G $(which wp) i18n make-pot . --ignore-domain
in case of memory limit issues)Describe what you would expect as the correct outcome
The resulting POT file should include all strings from components.js.
Let us know what environment you are running this on
Provide additional context/Screenshots
The debug message:
The source of this seems to be https://github.com/omgovich/react-colorful/blob/8681e3cbf6c7ca0c8ef3861a3c68d1a0ef1161fb/src/components/common/Interactive.tsx#L122-L123.
Might be a similar issue as in #255 and requires an upstream fix.
The text was updated successfully, but these errors were encountered: