PHP notice on updating theme translations with no updates

[grappler]

When running the update command and there are no updates there is a PHP warning with WP-CLI 2.0.1

wp language theme update twentysixteen
Warning: count(): Parameter must be an array or an object that implements Countable in phar:///bin/wp/vendor/wp-cli/language-command/src/WP_CLI/CommandWithTranslation.php on line 91
Warning: Invalid argument supplied for foreach() in phar:///bin/wp/vendor/wp-cli/language-command/src/WP_CLI/CommandWithTranslation.php on line 95
Success: Updated 0/0 translations.

[schlessera]

Additional information provided by @swissspidy in duplicate issue #60 :

---

I'm currently getting the following PHP warnings when updating language packs on a site:

PHP Warning:  Invalid argument supplied for foreach() in phar:///usr/bin/wp/vendor/wp-cli/language-command/src/WP_CLI/CommandWithTranslation.php on line 95
Warning: Invalid argument supplied for foreach() in phar:///usr/bin/wp/vendor/wp-cli/language-command/src/WP_CLI/CommandWithTranslation.php on line 95
Success: Updated 0/0 translations.

The code in question is here:

language-command/src/WP_CLI/CommandWithTranslation.php

Lines 88 to 103 in b17cdd8

	$obj_type = rtrim( $this->obj_type, 's' );
	$available_updates = $updates_per_type[ $obj_type ];
	$num_to_update += count( $available_updates );
	if ( ! Utils\get_flag_value( $assoc_args, 'dry-run' ) ) {
	// Update translations.
	foreach ( $available_updates as $update ) {
	WP_CLI::line( "Updating '{$update->Language}' translation for {$update->Name} {$update->Version}..." );
	$result = Utils\get_upgrader( $upgrader )->upgrade( $update );
	$results[] = $result;
	}
	}
	}

Looks like the code currently doesn't check whether $available_updates is actually set or is an array. We could add a continue statement in that case.

[ocean90]

@frozzare Did you forget to submit your change as a PR? 🙂

[frozzare]

@ocean90 yeah, sorry. Did get so late last night so I forgot about this 🙂