Support package names that differ from repository names

[Sidsector9]

As of now, only packages hosted on GitHub is supported.

Related to issue 4232

[danielbachhuber]

Why not use WP_CLI\Utils\http_request()?

[Sidsector9]

My bad, I was unaware of this function 😓 I'll make the changes

[danielbachhuber]

Can you include a test for this change, please? Generally, tests are required for all pull requests.

[Sidsector9]

@danielbachhuber I wanted to discuss this feature before adding tests, as you can see this fix only works for packages hosted on GitHub which restricts Git URLs hosted on different remote repositories like Bitbucket and GitLab. Do you have a better idea which I could implement?

[danielbachhuber]

I'll defer to @schlessera

[schlessera]

@Sidsector9 There's already a function to get the package name: self::get_package_name_and_version_from_dir_package()
I'm not sure it makes sense to request the composer.json file twice, as in general, names should match up. The check should be done after the package has been normally loaded.
Also, I think the actual action to take when we detect a mismatch should be to fix it automatically, with a warning. To fix it automatically, the "repositories" entry that was created needs to be adapted, to match the correct package name (instead of the GitHub repo name).
Would you be willing to investigate that approach, of fixing the actual problem?

[Sidsector9]

What's done until now:

1. Extract username/repository_name from the URL
2. Obtain package_name from composer.json file using raw GitHub URL
3. If this package_name is identical to the username/repository_name, then go with the normal flow, if not, then instead of username/repository_name, require will now refer to package_name and inside repositories, package_name will map to the repository URL.

.wp-cli/packages/composer.json will have a structure as

{
    "require": {
        "package_name": "dev-master"
    },
    "repositories": {
        "package_name": {
            "type": "vcs",
            "url": "github.com:user/repository_name.git"
        }
    }
}

[schlessera]

We need to add a test command that include the above problem to the wp-cli-test org and reference that package inside of the feature test instead. I'll create a package now.

[danielbachhuber]

@schlessera @Sidsector9 Should this land in the next release, or does it need more work?

[Sidsector9]

@danielbachhuber This is ready.

Required test was added.