Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flexibility of duplicating a product with/without images. #1672

Closed
benhuson opened this issue Nov 28, 2014 · 3 comments
Closed

Improve flexibility of duplicating a product with/without images. #1672

benhuson opened this issue Nov 28, 2014 · 3 comments
Assignees
Milestone

Comments

@benhuson
Copy link
Member

The wpsc_duplicate_product_attachment filter (#1671) relates to the attachment files attached to the product (post). It currently doesn't provide control over product image IDs stored in meta such as the featured image and '_wpsc_product_gallery'.

This could be address via new wpsc_duplicate_product_image and wpsc_duplicate_product_featured_image filters.

Currently, if you duplicate a product with a featured image but use the wpsc_duplicate_product_attachment filter to opt not to duplicate the attachment files, the featured image meta will still be copied and will reference the featured image ID of the product being duplicated. The '_wpsc_product_gallery' meta is also still copied.

Possibly future enhancements also include prompting a user whether they want to duplicate images when they click the duplicate product link.

See related: #1661

@JustinSainton
Copy link
Member

Punting to 4.1, unless you think you'll have time for this, @benhuson?

@benhuson
Copy link
Member Author

When #1929 is merged this ticket can be closed.

I've set up a new issue for tackling _wpsc_product_gallery.

@JustinSainton JustinSainton modified the milestones: 4.0, 4.1 Jun 26, 2015
@JustinSainton
Copy link
Member

Awesome, thanks @benhuson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants