Calculation of taxes logic has a "bug"

[1bigidea]

In my client site, we force country/state (since all orders are picked up on site). With the upgrade to 3.9.1 - our tax calculation stopped working.

I have tracked it down to lines 150 & 183 in /wpsc-taxes/controllers/taxes_controller.class.php - the logic tests for the presence of a meta field "wpec_taxes_taxable". It does not however check the value of the field.

No amount of jumping up and down on my product will make the wpec_taxes_taxable disappear from the meta - the value merely toggles from "on" to ""(empty).

It seems that we should be testing the value also.

I'll attach a pull request shortly for review.

[JustinSainton]

Confirmed - have had several reports of this, actually. Seems adding an || empty() check does the trick . Is that pretty much what you were thinking?

Was introduced in 8b013fd.

[jbeales]

So, who do I yell at for this not being released, at least as some sort of 3.9.1.1 urgent bug-fix or something?

This is the kind of thing that causes accounting nightmares for store owners, and causes developers to loose lots of time tracking down a known, and fixed 3 months ago, but not released, bug.

[JustinSainton]

✋

[jbeales]

I figured it was you ;) Maybe there should be a discussion around frequent bug-fix releases, especially ones that affect accounting.

[instinct]

Agreed. It's good for community but we need you to help keep an eye on things too :)

Sent from my iPhone

On 12/03/2015, at 3:09 pm, John Beales notifications@github.com wrote:

I figured it was you ;) Maybe there should be a discussion around frequent bug-fix releases, especially ones that affect accounting.

—
Reply to this email directly or view it on GitHub.

[JustinSainton]

👍 to any discussion around bug-fix frequency.