Add script enqueue que #2094
Merged
Add script enqueue que #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'sizes' parameter in the $metadata array passed through the 'wp_generate_attachment_metadata' is not guaranteed to be there, and therefore can cause the following notices/warnings: - PHP Notice: Undefined index: sizes in .../wp-e-commerce/wpsc-components/theme-engine-v2/helpers/template-engine.php on line 481 - PHP Warning: array_key_exists() expects parameter 2 to be array, null given in .../wp-e-commerce/wpsc-components/theme-engine-v2/helpers/template-engine.php on line 481
Because of the output buffering, there are many cases where naked calls to wp_enqueue_script will not work as it happens to early. This allows a CRUD interface for dealing with those scripts.
As per the previous commit, we need a way to enqueue scripts before they are registered. This allows us to do so as well as provide an interface for localizing variables within the WPSC namespace. Also includes a bit of cleanup in copy-billing.js
Serializes, ensures sane length and sanitizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update WPSC_Template_Engine to handle registering enqueued scripts.
Because of the output buffering, there are many cases where naked calls
to wp_enqueue_script will not work as it happens too early. This allows a
CRUD interface for dealing with those scripts and also allows us to
provide an interface for localizing variables within the WPSC namespace.