Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added refund date field #450

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

hilmerx
Copy link
Contributor

@hilmerx hilmerx commented Mar 6, 2021

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Adds date field to refund object. Is needed if you for example create monthly sales reports and need to see when a particular refund was made.

Does this close any currently open issues?

No

Any relevant logs, error output, GraphiQL screenshots, etc?

No

Any other comments?

Thank you for developing this! It's an awesome solution for headless WC.

Where has this been tested?

  • WordPress Version: 5.5.3
  • Operating system: Manjaro 20.2.1

@@ -63,6 +63,9 @@ protected function init() {
},
'capability' => 'list_users',
),
'date' => function() {
return ! empty( $this->wc_data->get_date_modified() ) ? $this->wc_data->get_date_modified() : null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this method.

@codeclimate
Copy link

codeclimate bot commented Mar 6, 2021

Code Climate has analyzed commit cadbb47 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.9% (0.0% change).

View more on Code Climate.

Copy link
Member

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hilmerx Sorry for the delayed review, and thanks for the great work. Approved 🤔

@kidunot89 kidunot89 merged commit 7ccd788 into wp-graphql:develop Mar 17, 2021
@kidunot89 kidunot89 added enhancement New feature or request new fields Feature adds new fields to existing types labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new fields Feature adds new fields to existing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants