-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core WP Options Support #220
Comments
@jasonbahl and @CodeProKid , wanted to get your thoughts on how far we should extend this. I'd like to keep parity with core, like so: http://v2.wp-api.org/reference/settings/ However, it'd also be nice to have some of the things McCue added to the spreadsheet in this repo: https://github.com/WP-API/wp-api-site-endpoints Maybe we will just throw the extra stuff in it's own extension like we're doing with everything outside of core. |
@hughdevore ya, let's turn our Pizza Party into a chat about this. . . |
@hughdevore here's my initial thoughts: We should definitely start with at least parity with the CORE REST API. Now, how it should look is where the real questions come in. We could do queries like: We could do queries like:
Or we could group fields into like Types / Fields:
Then again for mutations, we could have rootMutations like:
Or go the nested route, which I think is much more powerful and flexible. . .
I think we should discuss, as there are potential benefits to both, but I feel like grouping settings (similar to the WP Admin does with Settings Pages) makes a lot of sense. We could even go a step further and Group them all under "Settings" like so:
And mutations could then look like:
I don't see needing full CRUD support for options, as most of the time it's simply updating settings, so I can picture just needing an ===== Ultimately, after this rant, I'm leaning toward a single (or very few) Also, by grouping settings, we can make them accessible in different parts of the Graph. For example, if we have a
|
addressed by #254 We should add mutations soon too, but we I'm ok if do that as a post 1.0 feature. |
We should support queries and mutations for WP Core Options (site settings, etc)
The text was updated successfully, but these errors were encountered: