Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/#156 options queries #254

Closed
wants to merge 6 commits into from
Closed

Features/#156 options queries #254

wants to merge 6 commits into from

Conversation

hughdevore
Copy link
Contributor

No description provided.

jasonbahl
jasonbahl reviewed Oct 10, 2017
View reviewed changes
src/Data/DataSource.php Outdated
@@ -4,10 +4,12 @@
use GraphQL\Type\Definition\ResolveInfo;
use GraphQLRelay\Relay;

use PHPUnit\Runner\Exception;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hughdevore I don't think this is supposed to be here, eh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, dunno how that got added, will remove!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 92.191% when pulling 14053e5 on hughdevore:features/#156-optionsQueries into 9b5f637 on wp-graphql:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 10, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 92.191% when pulling 14053e5 on hughdevore:features/#156-optionsQueries into 9b5f637 on wp-graphql:develop.

@coveralls
Copy link

coveralls commented Oct 10, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 92.191% when pulling 9448eb7 on hughdevore:features/#156-optionsQueries into 9b5f637 on wp-graphql:develop.

@jasonbahl
Copy link
Collaborator

@hughdevore I'm going to close this per our Slack conversation

@jasonbahl jasonbahl closed this Oct 10, 2017
@coveralls
Copy link

coveralls commented Oct 10, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 92.191% when pulling 9178515 on hughdevore:features/#156-optionsQueries into 9b5f637 on wp-graphql:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 92.191% when pulling 9178515 on hughdevore:features/#156-optionsQueries into 9b5f637 on wp-graphql:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 92.191% when pulling 9178515 on hughdevore:features/#156-optionsQueries into 9b5f637 on wp-graphql:develop.

@jasonbahl jasonbahl mentioned this pull request Nov 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbahl jasonbahl jasonbahl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hughdevore @coveralls @jasonbahl