Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of asPreview argument #2879

Closed
jasonbahl opened this issue Aug 3, 2023 · 0 comments · Fixed by #2880
Closed

Improve description of asPreview argument #2879

jasonbahl opened this issue Aug 3, 2023 · 0 comments · Fixed by #2880

Comments

@jasonbahl
Copy link
Collaborator

What problem does this address?

The asPreview argument could be more clear so users know what to expect.

Per feedback in #2876, there's room for improvement in the description of the asPreview argument.

What is your proposed solution?

Update the description to something like the following:

"Whether to return the Preview Node instead of the Published Node. When the ID of a Node is provided along with asPreview being set to true, the preview node with un-published changes will be returned instead of the published node. If no preview node exists or the requestor doesn't have proper capabilities to preview, no node will be returned."

What alternatives have you considered?

No response

Additional Context

No response

jasonbahl added a commit that referenced this issue Aug 3, 2023
…-argument

fix: increase clarity of the description of `asPreview` argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant