Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static $allowed_post_types and $allowed_taxonomies causing funky issues #815

Closed
jasonbahl opened this issue Apr 20, 2019 · 0 comments
Closed

Static $allowed_post_types and $allowed_taxonomies causing funky issues #815

jasonbahl opened this issue Apr 20, 2019 · 0 comments
Assignees
@jasonbahl
Labels
Type: Bug Something isn't working

Comments

@jasonbahl
Copy link
Collaborator

The static vars:

WPGraphQL::$allowed_post_types and WPGraphQL::$allowed_taxonomies are causing some funky issues, specifically in unit tests.

Swapping out to use WPGraphQL::get_allowed_post_types() and WPGraphQL::get_allowed_taxonomies() fixes the funkiness.
@jasonbahl jasonbahl added the Type: Bug Something isn't working label Apr 20, 2019
@jasonbahl jasonbahl self-assigned this Apr 20, 2019
jasonbahl added a commit to jasonbahl/wp-graphql that referenced this issue Apr 20, 2019
@jasonbahl
🐛 BUGFIX
b8f7c87 
wp-graphql#815 - swapping static allowed_post_types and allowed_taxonomies with the get_* functions fixes some funky issues in unit tests, specifically tests that try to register new post types/taxonomies
@jasonbahl jasonbahl mentioned this issue Apr 20, 2019
Merged
jasonbahl added a commit that referenced this issue Apr 20, 2019
@jasonbahl
Merge pull request #816 from jasonbahl/bug/#815-static-allowed-vars-c…
80a5841 
…ause-issues-in-tests

🐛 Bug/#815 static allowed vars cause issues in tests
@jasonbahl jasonbahl mentioned this issue Apr 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonbahl jasonbahl

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonbahl