Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All inputs that expect an ID (global or integer) should be of Type ID in the Schema #997

Open
jasonbahl opened this issue Nov 3, 2019 · 3 comments
Open

All inputs that expect an ID (global or integer) should be of Type ID in the Schema #997

jasonbahl opened this issue Nov 3, 2019 · 3 comments
Labels
Compat: Breaking Change This is a breaking change to existing functionality Component: Input effort: high more than a week impact: med minor perf improvements, fix broad userbase issues ObjectType: Comment ObjectType: Post Issues related to the Post object type in WP ObjectType: Term ObjectType: User Status: 🚀 Actionable Issues that have been curated, have enough info to take action, and are ready to be worked on Type: Enhancement New feature or request
Milestone
v2.0

Comments

@jasonbahl
Copy link
Collaborator

We're breaking #109 into 2 issues.

This issue should address making all input Types that expect an ID of some sort to be of Type ID.

Resolution can still be inconsistent (for now), but the Schema itself should all be of Type ID so that we can make resolution consistent in the future.
@jasonbahl jasonbahl added the Compat: Breaking Change This is a breaking change to existing functionality label Nov 3, 2019
@jasonbahl jasonbahl added this to the 1.0 release milestone Nov 3, 2019
This was referenced Nov 3, 2019
Closed
Closed
@CodeProKid CodeProKid mentioned this issue Nov 19, 2019
Closed
@CodeProKid CodeProKid added Component: Input ObjectType: Comment ObjectType: Post Issues related to the Post object type in WP ObjectType: Term ObjectType: User Status: 🚀 Actionable Issues that have been curated, have enough info to take action, and are ready to be worked on effort: high more than a week impact: med minor perf improvements, fix broad userbase issues labels Jan 17, 2020
@jasonbahl jasonbahl modified the milestones: 1.0 release, 1.0-rc Jun 30, 2020
@jasonbahl jasonbahl modified the milestones: 1.0-rc, 1.0 release Sep 23, 2020
@moonmeister moonmeister mentioned this issue Apr 7, 2021
Open
@bhardie bhardie mentioned this issue Mar 29, 2022
Closed
@justlevine justlevine added the Type: Enhancement New feature or request label Apr 1, 2022
This was referenced Apr 2, 2022
Closed
Merged
@jasonbahl jasonbahl modified the milestones: 1.0 release, v2.0 Apr 4, 2022
@stale
Copy link

stale bot commented Aug 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 2, 2022
@stale
Copy link

stale bot commented Sep 1, 2022

This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issue and mark this as a related issue.

@stale stale bot closed this as completed Sep 1, 2022
@justlevine justlevine reopened this Sep 2, 2022
@stale stale bot removed the stale label Sep 2, 2022
@moonmeister
Copy link
Collaborator

commenOn for Comment Mutations currently requires Int

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat: Breaking Change This is a breaking change to existing functionality Component: Input effort: high more than a week impact: med minor perf improvements, fix broad userbase issues ObjectType: Comment ObjectType: Post Issues related to the Post object type in WP ObjectType: Term ObjectType: User Status: 🚀 Actionable Issues that have been curated, have enough info to take action, and are ready to be worked on Type: Enhancement New feature or request
Projects
WPGraphQL Issue Triage
Status: 🛑 On Hold
Milestone
v2.0
Development

No branches or pull requests
5 participants
@jasonbahl @moonmeister @CodeProKid @josephfusco @justlevine