Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete User Mutation #1231

Merged
merged 1 commit into from Apr 13, 2020
Merged

Delete User Mutation #1231

merged 1 commit into from Apr 13, 2020

Conversation

renatonascalves
Copy link
Collaborator

@renatonascalves renatonascalves commented Apr 9, 2020

Passing the user ID to the current_user_can function in the deleteUser mutation so that extensions and plugins can properly extend it.

More background information here: #143

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #1231 into develop will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1231   +/-   ##
========================================
  Coverage    63.76%   63.76%           
========================================
  Files          165      165           
  Lines         9530     9530           
========================================
  Hits          6077     6077           
  Misses        3453     3453           
Impacted Files Coverage Δ
src/Mutation/UserDelete.php 58.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00596e9...eec3bf9. Read the comment docs.

@renatonascalves
Copy link
Collaborator Author

renatonascalves commented Apr 11, 2020

@jasonbahl Is it okay to merge this?

@jasonbahl jasonbahl merged commit f20d765 into develop Apr 13, 2020
This was referenced Apr 13, 2020
@jasonbahl jasonbahl deleted the delete-user branch April 13, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants