PostObjectMutations #140

jasonbahl · 2017-05-23T20:55:06Z

This introduces postObjectMutations, and includes tests for said mutations.

Also includes lots of formatting changes, which I know I should do in separate PRs, but whatever, deal with it 😜 (I'll really try to stop doing that though, because I know it's annoying to try and code review when there's a bunch of misc formatting changes included)

====

Here's an example of trying to create a page but not being allowed to because I don't have permissions.

So, I add my Authorization headers to the request (using Basic auth in this example), then I repeat the mutation and you can see data created!

Then I do a follow-up updatePage mutation to change the title, and you see the same page is returned, just with a new title.

…o feature/graphql-insights

…upport. Misc formatting updates.

- Fixes to AvatarType

Update the WPInputObjectType to accept a $config array as the input Update the CommentConnectionArgs to use the $config array for the parent input Update the PostObjectConnectionArgs to use the $config array for the parent input Update the PostObjectConnectionArgsDateQuery to use the $config array for the parent input Update the TermObjectConnectionArgs to use the $config array for the parent input Update the TermObjectConnectionResolver to use the $config array for the parent input Update the UserConnectionArgs to use the $config array for the parent input

…k fields

Introduce a shared “postObjectMutation” class for the CRUD classes to utilize Introduce PostObjectDelete class for handling deletes for postObjects Introduce PostObjectCreate class for handling inserts for postObjects Introduce PostObjectUpdate class for handling updates for postObjects Update /tests/test-nodes.php to include a query with variables Update /tests/test-plugin-queries.php to set the role properly Update /tests/test-post-connection-queries.php to set the role properly Update /tests/test-post-object-queries.php to set the role properly Add unit test for Relay Mutation Schema Add unit test for Post Object Mutations

…o feature/#4-post-mutations

coveralls · 2017-05-23T22:15:25Z

Coverage decreased (-0.01%) to 79.35% when pulling 973b769 on jasonbahl:feature/#4-post-mutations into 5ab9cd1 on wp-graphql:master.

coveralls · 2017-05-23T22:19:25Z

Coverage decreased (-0.01%) to 79.35% when pulling 3abcb39 on jasonbahl:feature/#4-post-mutations into 5ab9cd1 on wp-graphql:master.

coveralls · 2017-05-24T15:50:43Z

Coverage increased (+0.05%) to 81.966% when pulling ef01be1 on jasonbahl:feature/#4-post-mutations into 60c8a0e on wp-graphql:master.

jasonbahl · 2017-05-24T19:57:25Z

.travis.yml

@@ -33,7 +33,7 @@ matrix:
 # Composer package installation
 install:
  # Install composer packages, will also trigger dump-autoload
-  - composer install --no-interaction


Travis tests were bombing because of this

jasonbahl · 2017-05-24T19:58:55Z

src/AppContext.php

+	 */
+	public function __construct() {
+
+		$this->config = apply_filters( 'graphql_app_context_config', $this->config );


This will allow the AppContext to have data added to it and accessed throughout the resolve tree. . .not used by anything (yet) but will be useful for WPGraphQL Insights / Apollo Optics support

jasonbahl · 2017-05-24T19:59:07Z

src/Data/Config.php

@@ -82,9 +82,7 @@ public function graphql_wp_query_cursor_pagination_support( $where, \WP_Query $q
 				} else {


just formatting changes on this file

jasonbahl · 2017-05-24T20:00:05Z

src/Data/ConnectionResolver.php

@@ -32,7 +32,7 @@ public static function resolve( $source, $args, AppContext $context, ResolveInfo
 		$query_args  = static::get_query_args( $source, $args, $context, $info );
 		$query       = static::get_query( $query_args );
 		$array_slice = self::get_array_slice( $query, $args );
-		$connection  = static::get_connection( $array_slice, $args, $query );
+		$connection  = static::get_connection( $query, $array_slice, $source, $args, $context, $info );


Adding more params so context can be passed throughout easier

jasonbahl · 2017-05-24T20:00:22Z

src/Data/ConnectionResolver.php

-	 *
-	 *
-	 */
-	public static function get_query_order( $args, $query_args ) {


removed because this never gets called now

jasonbahl · 2017-05-24T20:01:11Z

src/Type/Avatar/AvatarType.php

@@ -1,4 +1,5 @@
 <?php


just formatting in this file

jasonbahl · 2017-05-24T20:01:30Z

src/Type/Comment/CommentType.php

@@ -4,7 +4,6 @@
 use GraphQL\Type\Definition\ResolveInfo;


just formatting changes to this file

jasonbahl · 2017-05-24T20:02:18Z

src/Type/Comment/Connection/CommentConnectionArgs.php

-			self::$fields = $fields;
-
-		}
+			self::$fields = self::prepare_fields( $fields, 'commentArgs' );


make use of the prepare_fields method which handles sorting and filtering the fields.

jasonbahl · 2017-05-24T20:02:57Z

src/Type/Comment/Connection/CommentConnectionArgs.php

-
-			self::$comments_orderby_enum = new EnumType([
+		if ( null === self::$comments_orderby_enum ) :
+			self::$comments_orderby_enum = new WPEnumType([


convert to use WPEnumType to take advantage of filters, etc

Are we using just EnumType other places? Should probably get an issue going to convert all EnumType's to WPEnumType

@CodeProKid I tried to sweep and convert them all to WPEnumType. . .but I can double check to make sure I got em all

jasonbahl · 2017-05-24T20:03:13Z

src/Type/Comment/Connection/CommentConnectionDefinition.php

@@ -35,7 +35,7 @@ class CommentConnectionDefinition {
 	 */


just formatting adjustments in this file

jasonbahl · 2017-05-24T20:09:16Z

src/Type/PostObject/Connection/PostObjectConnectionDefinition.php

@@ -45,8 +45,7 @@ public static function debug_fields( $connection_name ) {
 			self::$debug_fields = [];


just formatting in this file

jasonbahl · 2017-05-24T20:10:17Z

src/Type/PostObject/Connection/PostObjectConnectionResolver.php

 	 *
 	 * @return array
 	 */
-	public static function get_connection( array $items, array $args, $query ) {
+	public static function get_connection( $query, array $items, $source, array $args, AppContext $context, ResolveInfo $info ) {


update to play nice with \Data\ConnectionResolver class

jasonbahl · 2017-05-24T20:16:19Z

wp-graphql.php

@@ -250,7 +250,11 @@ public static function get_allowed_post_types() {
 			/**
 			 * Get all post_types that have been registered to "show_in_graphql"
 			 */
-			$post_types = get_post_types( [ 'show_in_graphql' => true ] );
+			$post_types = get_post_types(


codesniffer whining

jasonbahl · 2017-05-24T20:17:34Z

wp-graphql.php

@@ -371,27 +379,35 @@ public static function do_graphql_request( $request, $operation_name = '', $vari
 			 * @param            AppContext      object The AppContext object containing all of the
 			 *                                   information about the context we know at this point
 			 */
-			$variables = ( array ) json_decode( $variables );
+			if ( ! is_array( $variables ) ) {


some clients (graphiql) send variables as a string, and some clients (Apollo) send variables as JSON, so this normalizes the $variables so either method will properly execute.

jasonbahl · 2017-05-24T20:19:07Z

wp-graphql.php

 			 */
-			$executable_schema = apply_filters( 'graphql_executable_schema', $executable_schema, $request, $variables, $app_context );
+			$schema = new \WPGraphQL\WPSchema( $executable_schema );


Instead of filtering here, I created a new WPSchema class, and apply filters in there, where so the filtered methods can access methods within the WPSchma class. . .this is pretty essential for WPGraphQL Insights / Apollo Optics support

…o feature/#4-post-mutations # Conflicts: # src/Type/PostObject/PostObjectType.php # src/Type/TermObject/TermObjectType.php # wp-graphql.php

…ahl/wp-graphql into feature/#4-post-mutations # Conflicts: # wp-graphql.php

coveralls · 2017-05-24T22:24:05Z

Coverage decreased (-0.3%) to 85.048% when pulling cd8c754 on jasonbahl:feature/#4-post-mutations into f565f3e on wp-graphql:master.

coveralls · 2017-05-24T22:27:14Z

Coverage decreased (-0.3%) to 85.048% when pulling cd8c754 on jasonbahl:feature/#4-post-mutations into f565f3e on wp-graphql:master.

CodeProKid · 2017-05-25T19:21:49Z

src/Type/Comment/Connection/CommentConnectionDefinition.php

@@ -35,7 +35,7 @@ class CommentConnectionDefinition {
 	 */
 	public static function connection() {

-		if ( null === self::$connection ) {
+		if ( null === self::$connection ) :


Would be good to get a developers handbook going for rules on stuff like this. When to use : vs {. Or at least an issue so we can start documenting these things.

@CodeProKid ya, I go back and forth on my usage sometimes. . .I usually prefer brackets, but use colon for longer blocks as it's more explicit where it's ending. . .but ya, we can definitely decide on a standard on when to go to colon vs. brackets. . .like a certain size of code block being wrapped or something

CodeProKid

@jasonbahl some stuff in here. Let me know if you have any Q's.

CodeProKid · 2017-05-25T19:25:06Z

src/Type/Enum/PostStatusEnumType.php

+		$config = [
+			'name' => 'status',
+			'description' => __( 'The status of the object.', 'wp-graphql' ),
+			'values' => self::values(),


Formatting needed on this array for consistency.

CodeProKid · 2017-05-25T19:25:13Z

src/Type/Enum/MimeTypeEnumType.php

+		$config = [
+			'name' => 'mimeType',
+			'description' => __( 'The MimeType of the object', 'wp-graphql' ),
+			'values' => self::values(),


Formatting needed on this array for consistency.

CodeProKid · 2017-05-25T19:27:44Z

src/Type/Enum/RelationEnumType.php

+		$config = [
+			'name' => 'relation',
+			'description' => __( 'The logical relation between each item in the array when there are more than one.', 'wp-graphql' ),
+			'values' => self::values(),


Formatting needed on this array for consistency.

CodeProKid · 2017-05-25T19:27:52Z

src/Type/Enum/TaxonomyEnumType.php

+		$config = [
+			'name' => 'taxonomyEnum',
+			'description' => __( 'Allowed taxonomies', 'wp-graphql' ),
+			'values' => self::values(),


Formatting needed on this array for consistency.

CodeProKid · 2017-05-25T20:45:43Z

src/Type/PostObject/Mutation/PostObjectCreate.php

+	public static function mutate( \WP_Post_Type $post_type_object ) {
+
+		if ( null === self::$mutation ) {
+			self::$mutation = [];


Couldn't you just set $mutation to an empty array when you define it above? What's the upside of having it be null, and then define it here?

no upside. changed this.

CodeProKid · 2017-05-25T21:40:53Z

src/Type/PostObject/Mutation/PostObjectUpdate.php

+	public static function mutate( \WP_Post_Type $post_type_object ) {
+
+		if ( null === self::$mutation ) {
+			self::$mutation = [];


Same comment as above.

CodeProKid · 2017-05-25T21:45:30Z

src/Type/PostObject/Mutation/PostObjectUpdate.php

+					if ( ! current_user_can( $post_type_object->cap->edit_posts ) ) {
+						// translators: the $post_type_object->graphql_single_name placeholder is the name of the object being mutated
+						throw new \Exception( sprintf( __( 'Sorry, you are not allowed to update a %1$s', 'wp-graphql' ), $post_type_object->graphql_single_name ) );
+					}


I wonder if it would make sense to abstract these cap checks into a postObjectMutateCheck utility class or something. Just a thought. Not required before merge.

Created an issue to work on this: #143

CodeProKid · 2017-05-25T21:46:44Z

src/Type/PostObject/Mutation/PostObjectUpdate.php

+					/**
+					 * Insert the post and retrieve the ID
+					 */
+					$post_id = wp_update_post( $post_args );


As with wp_insert_post() you actually have to pass true as the second param. See docs: https://developer.wordpress.org/reference/functions/wp_update_post/

CodeProKid · 2017-05-25T21:50:25Z

src/Type/PostObject/Mutation/PostObjectUpdate.php

+		 */
+		return array_merge(
+			[
+				'id'      => [


What is your reformator trying to align this with? haha.

CodeProKid · 2017-05-25T22:02:24Z

tests/test-post-object-mutations.php

+		] );
+		$this->subscriber       = $this->factory->user->create( [
+			'role' => 'subscriber',
+		] );


Indentation here is pretty ugly.

…o feature/wp-graphql#116-ancestor-support # Conflicts: # src/Type/PostObject/PostObjectType.php # src/Type/TermObject/TermObjectType.php # wp-graphql.php

jasonbahl · 2017-05-26T16:27:09Z

@CodeProKid Updated this PR and replied to comments. Thanks!

coveralls · 2017-05-26T16:32:11Z

Coverage decreased (-0.3%) to 85.033% when pulling d968f6e on jasonbahl:feature/#4-post-mutations into f565f3e on wp-graphql:master.

jasonbahl added 18 commits April 29, 2017 07:23

no message

86221cc

Merge branch 'master' of https://github.com/wp-graphql/wp-graphql int…

0567c5c

…o feature/graphql-insights

Misc changes for GraphQL insights support and GraphQL subscriptions s…

23949c5

…upport. Misc formatting updates.

Fix variable input to be formatted properly before execution

4cc2eb4

Minor formatting changes, removing debug code

8a7ba39

- Slight refactor to EnumTypes

edee057

- Fixes to AvatarType

Update PostObjectType, adjusting definition of toPing, pinged and lin…

5ede5c4

…k fields

Update composer files to include new Autoloading classes for mutations

4ec34c9

Revert template_redirect hook priority change

96a9350

Removing debug code

eab5f5c

Updating travis script

b1e89fc

reverting composer.lock change

470f733

Merge branch 'master' of https://github.com/wp-graphql/wp-graphql int…

973b769

…o feature/#4-post-mutations

Merge branch 'master' of https://github.com/wp-graphql/wp-graphql int…

3abcb39

…o feature/#4-post-mutations

jasonbahl added 3 commits May 23, 2017 16:53

Minor refactoring per Coveralls feedback

42eaa93

Merge branch 'master' into feature/#4-post-mutations

8f5c6a7

Adjusting Avatar Type and Avatar Test

ef01be1

jasonbahl commented May 24, 2017

View reviewed changes

jasonbahl added 4 commits May 24, 2017 15:49

Merge branch 'master' into feature/#4-post-mutations

24769fd

Merge branch 'master' of https://github.com/wp-graphql/wp-graphql int…

e3026e2

…o feature/#4-post-mutations # Conflicts: # src/Type/PostObject/PostObjectType.php # src/Type/TermObject/TermObjectType.php # wp-graphql.php

Merge branch 'feature/#4-post-mutations' of https://github.com/jasonb…

694c99e

…ahl/wp-graphql into feature/#4-post-mutations # Conflicts: # wp-graphql.php

no message

cd8c754

jasonbahl requested a review from CodeProKid May 25, 2017 03:08

CodeProKid reviewed May 25, 2017

View reviewed changes

CodeProKid requested changes May 25, 2017

View reviewed changes

jasonbahl mentioned this pull request May 26, 2017

Abstract mutation permission checks #143

Closed

Merge branch 'master' of https://github.com/wp-graphql/wp-graphql int…

d968f6e

…o feature/wp-graphql#116-ancestor-support # Conflicts: # src/Type/PostObject/PostObjectType.php # src/Type/TermObject/TermObjectType.php # wp-graphql.php

jasonbahl merged commit 6cb33f7 into wp-graphql:master May 26, 2017

jasonbahl mentioned this pull request Jun 24, 2017

Post Mutations #4

Closed

		@@ -82,9 +82,7 @@ public function graphql_wp_query_cursor_pagination_support( $where, \WP_Query $q
		} else {

		@@ -45,8 +45,7 @@ public static function debug_fields( $connection_name ) {
		self::$debug_fields = [];

PostObjectMutations #140

PostObjectMutations #140

Conversation

jasonbahl commented May 23, 2017 • edited

coveralls commented May 23, 2017 • edited

coveralls commented May 23, 2017 • edited

coveralls commented May 24, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented May 24, 2017 • edited

coveralls commented May 24, 2017 • edited

Choose a reason for hiding this comment

jasonbahl May 25, 2017 • edited

Choose a reason for hiding this comment

CodeProKid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasonbahl commented May 26, 2017

coveralls commented May 26, 2017 • edited

jasonbahl commented May 23, 2017 •

edited

coveralls commented May 23, 2017 •

edited

coveralls commented May 23, 2017 •

edited

coveralls commented May 24, 2017 •

edited

coveralls commented May 24, 2017 •

edited

coveralls commented May 24, 2017 •

edited

jasonbahl May 25, 2017 •

edited

coveralls commented May 26, 2017 •

edited