Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#6 term mutations #149

Merged
merged 7 commits into from
Jun 19, 2017

Conversation

jasonbahl
Copy link
Collaborator

This adds initial TermObjectMutations (Unit Tests coming shortly)

Below is an example of creating, updating and deleting a Category via GraphQL queries:
term-mutations

This adds initial crud mutations for term objects
This adds initial CRUD mutations for TermObjects

examples:

mutation{
  createCategory(input:{
    name:"GraphQLCat 2"
    clientMutationId:"SomeID"
  }){
    clientMutationId
    category{
      name
      id
      link
    }
  }
}

mutation {
  updateCategory(input:{
    id:"Y2F0ZWdvcnk6MjA0",
    clientMutationId:"someId"
    description:"Some Updated Description, dawg"
  }){
    category{
      description
      id
      link
      slug
    }
  }
}

mutation{
  deleteCategory(
    input:{
      id:"Y2F0ZWdvcnk6MjAy"
      clientMutationId:"SomeId"
    }
  ){
    category{
      id
      link
      name
    }
  }
}
- Removed an unnecessary exception that was added in my last commit
@coveralls
Copy link

coveralls commented Jun 15, 2017

Coverage Status

Coverage decreased (-1.9%) to 83.685% when pulling 1dbe024 on jasonbahl:feature/#6-term-mutations into ca51749 on wp-graphql:master.

- Adding unit tests
- Adding unit tests
- Fixed a bug in termObjectDelete that allowed terms of other types to be deleted if their ID was passed instead of an ID of the type being deleted
- Adding unit tests
- Fixed a bug in termObjectDelete that allowed terms of other types to be deleted if their ID was passed instead of an ID of the type being deleted
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 84.96% when pulling 5c54f39 on jasonbahl:feature/#6-term-mutations into ca51749 on wp-graphql:master.

@coveralls
Copy link

coveralls commented Jun 15, 2017

Coverage Status

Coverage decreased (-0.4%) to 85.184% when pulling 5c54f39 on jasonbahl:feature/#6-term-mutations into ca51749 on wp-graphql:master.

Copy link
Contributor

@hughdevore hughdevore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonbahl, great job! What is the deal with coveralls? Also, @CodeProKid may want to double check this as well. 🔬

@jasonbahl jasonbahl added Architecture Status: In Review Needs to be reviewed by a project maintainer before merge Status: In Progress labels Jun 16, 2017
@coveralls
Copy link

coveralls commented Jun 16, 2017

Coverage Status

Coverage increased (+0.3%) to 85.242% when pulling 5ba8cd1 on jasonbahl:feature/#6-term-mutations into a1af687 on wp-graphql:master.

@jasonbahl jasonbahl requested review from CodeProKid and removed request for CodeProKid June 19, 2017 16:45
@jasonbahl jasonbahl merged commit 61a4cba into wp-graphql:master Jun 19, 2017
@jasonbahl jasonbahl mentioned this pull request Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Status: In Progress Status: In Review Needs to be reviewed by a project maintainer before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants