Release/v1.1.2 #1682
Merged
Release/v1.1.2 #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perly with WPGraphQL should they be passed to a node query - Update cases of menu item IDs to be `post:$id` instead of `nav_menu_item:$id` - Update tests to test that both the old nav_menu_item:$id and post:$id work for nav menu item node queries to support previously issued IDs
…sistent Bug/#1675 menu item ids inconsistent
## Bugfixes - MenuItems are stored in the post table and should use the post loader. To use the post loader properly, the menu item IDs should be encoded as `post:$id` but were encoded as `nav_menu_item:$id` which breaks the principles of the Relay spec. This fixes that. MenuItems now output ids encoded as `post:$id`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Bugfixes
post:$idbut were encoded asnav_menu_item:$idwhich breaks the principles of the Relay spec. This fixes that. MenuItems now output ids encoded aspost:$id