Change docker image names specific to wp/php build #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkelnar
force-pushed
the
docker-image-cleanup
branch
from
2505860
to
b0b13d1
Compare
jasonbahl
reviewed
Jun 22, 2021
jasonbahl
reviewed
Jun 22, 2021
jasonbahl
approved these changes
Jun 22, 2021
jasonbahl
requested changes
Jun 22, 2021
markkelnar
commented
Jun 23, 2021
jasonbahl
approved these changes
Jun 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When we build the wp-graphql docker images, use a name that better represents the WP and PHP version used for the image. Should allow us to reuse images as well as potentially deploy to docker hub.
Does this close any currently open issues?
Related to wp-graphql/wp-graphql-smart-cache#1
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
…
Where has this been tested?
Operating System: …
WordPress Version: …