Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old GraphiQL JavaScript #2286

Merged

Conversation

jasonbahl
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This PR cleans up the repo by removing the old JavaScript that was used to build WPGraphiQL.

The new GraphiQL exists under the /packages directory, and the JavaScript under /src/Admin/GraphiQL is no longer used.

The PR does the following:

  • remove old GraphiQL JavaScript
  • update docs with links to new JavaScript files
  • remove reference to old JavaScript files from composer.json
  • remove reference to old JavaScript files from codeception.dist.yml

- update docs with links to new JavaScript files
- remove reference to old JavaScript files from composer.json
- remove reference to old JavaScript files from codeception.dist.yml
@jasonbahl jasonbahl added scope: build scripts Affects build scripts, CI workflows, and automation. javascript Pull requests that update Javascript code labels Mar 8, 2022
@jasonbahl jasonbahl self-assigned this Mar 8, 2022
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12542 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Mar 8, 2022

Code Climate has analyzed commit 6490368 and detected 0 issues on this pull request.

View more on Code Climate.

@jasonbahl jasonbahl merged commit 70dc88b into wp-graphql:develop Mar 8, 2022
@jasonbahl jasonbahl mentioned this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code scope: build scripts Affects build scripts, CI workflows, and automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant