Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- changes commentTypeNotIn field to a listOf String instead of String #2325

Open
wants to merge 12 commits into
base: v2.0/develop
Choose a base branch
from
Open

- changes commentTypeNotIn field to a listOf String instead of String #2325

wants to merge 12 commits into from
+149 −20

Commits on Apr 2, 2022

  1. fix: change commentTypeNotIn to string[]

    @justlevine
    justlevine committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    d1efebc View commit details
    Browse the repository at this point in the history

  2. fix: map commentType args to query

    @justlevine
    justlevine committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    d20cc7c View commit details
    Browse the repository at this point in the history

  3. tests: test filtering by commentType

    @justlevine
    justlevine committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    7ebcb1a View commit details
    Browse the repository at this point in the history

  4. tests: use databaseId over deprecated commentId

    @justlevine
    justlevine committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    ec8df2f View commit details
    Browse the repository at this point in the history

  5. chore: revert commentTypeNotIn schema change

    @justlevine
    justlevine committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    58f4a28 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Revert "chore: revert commentTypeNotIn schema change" 

    This reverts commit 58f4a28.
    @jasonbahl
    jasonbahl committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    d5f7b04 View commit details
    Browse the repository at this point in the history

  2. Revert "Revert "chore: revert commentTypeNotIn schema change"" 

    This reverts commit d5f7b04.
    @jasonbahl
    jasonbahl committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    d3300cb View commit details
    Browse the repository at this point in the history

  3. - changes commentTypeNotIn field to a listOf String instead of String

    @jasonbahl
    jasonbahl committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    a9a7394 View commit details
    Browse the repository at this point in the history

  4. - add test for back compat filter

    @jasonbahl
    jasonbahl committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    41afc1a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix/commentType-connection-where-args' into v2.0/fix/co… 

    …mmentTypeNotIn-change-to-listOf

# Conflicts:
#	tests/wpunit/CommentConnectionQueriesTest.php

--- adds a test to ensure filtering the field type works, as documented
    @jasonbahl
    jasonbahl committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    efc107c View commit details
    Browse the repository at this point in the history

  6. - update workflows to run for the v2.0/develop branch

    @jasonbahl
    jasonbahl committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    84dff63 View commit details
    Browse the repository at this point in the history

  7. - code formatting fix

    @jasonbahl
    jasonbahl committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    233c113 View commit details
    Browse the repository at this point in the history