fix: add post_lock check on edit/delete mutation #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
jasonbahl
changed the title
jasonbahl
reviewed
Dec 1, 2022
jasonbahl
reviewed
Dec 1, 2022
jasonbahl
reviewed
Dec 1, 2022
jasonbahl
requested changes
Dec 1, 2022
There was a problem hiding this comment.
I suggested some changes, and Github bot found some as well.
Also, we should add some tests:
- Test that a post that's currently locked cannot be mutated by default
- Test that passing
ignoreEditLockallows the mutation to proceed, assuming the mutation is being done by a user with permission to mutate - Test that passing
ignoreEditLockdoesn't allow a public user to bypass other permission checks
Co-authored-by: Jason Bahl <jasonbahl@mac.com>
Co-authored-by: Jason Bahl <jasonbahl@mac.com>
release: v1.13.8
jasonbahl
previously approved these changes
Feb 7, 2023
|
Code Climate has analyzed commit 37efad5 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Check is the post if locked by another user when post mutation to update/delete. Provide an override option.
Does this close any currently open issues?
closes 379
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
Where has this been tested?
Operating System: …
WordPress Version: …