Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use last working version of xdebug for php7 #2669

Merged

Conversation

markkelnar
Copy link
Contributor

@markkelnar markkelnar commented Dec 8, 2022

What does this implement/fix? Explain your changes.

Building images for PHP version 7 fails because xdebug library dropped support for php 7. This change makes use of the last known working version for PHP 7.*. Leaving PHP 8 to use latest xdebug library.

This error will be seen in github tests and local develop where a docker image is built.

Screen Shot 2022-12-08 at 2 22 14 PM

Drop PHP 7.3 and PHP 7.4 support

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System:

WordPress Version:

@codeclimate
Copy link

codeclimate bot commented Dec 8, 2022

Code Climate has analyzed commit 25730df and detected 0 issues on this pull request.

View more on Code Climate.

@markkelnar markkelnar changed the title Use last working version of xdebug for php7 ci: Use last working version of xdebug for php7 Dec 8, 2022
@jasonbahl jasonbahl merged commit a4085e6 into wp-graphql:develop Dec 8, 2022
@markkelnar markkelnar deleted the fix-docker-xdebug-for-php7 branch December 9, 2022 15:01
@jasonbahl jasonbahl mentioned this pull request Dec 9, 2022
justlevine added a commit to AxeWP/wp-graphql-gravity-forms that referenced this pull request Dec 21, 2022
justlevine added a commit to justlevine/wp-graphql-gravity-forms that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants