fix: replace double negation with true #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there, I found a small issue A boolean cast via double negation (!!) is redundant when used as a condition The condition can be written without the extra cast and behave exactly the same.
|
Code Climate has analyzed commit e9260d8 and detected 0 issues on this pull request. View more on Code Climate. |
cesarkohl
changed the title
jasonbahl
approved these changes
Jun 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, I found a small issue.
A boolean cast via double negation (!!) is redundant when used as a condition The condition can be written without the extra cast and behave exactly the same.
In other words:
!!trueistrue.