Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support STEP_DEBUG in Code Quality workflow #2841

Merged
merged 1 commit into from Jun 29, 2023

Conversation

justlevine
Copy link
Collaborator

@justlevine justlevine commented Jun 29, 2023

What does this implement/fix? Explain your changes.

This PR adds support for using STEP_DEBUG in the Code Quality workflow to run phpstan in debug mode.

This change will allow better debugging of CI failures that cannot be easily replicated locally.
For example: if hypothetically a leaky dependency causes phpstan to throw an Out of Memory issues, this would let us pinpoint that the error isnt occurring due to the contents of the PR

To test

  1. Visit the Code Quality action on this PR
  2. Click 'Rerun All Jobs'
  3. Check Enable debug logging and click Re-run jobs.
  4. Check log for Run PHPStan to see the PHPStan messages output by the --debug flag.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

image

Any other comments?

Where has this been tested?

Operating System: GitHub Actions

WordPress Version: N/A

@codeclimate
Copy link

codeclimate bot commented Jun 29, 2023

Code Climate has analyzed commit a87c02f and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine marked this pull request as ready for review June 29, 2023 21:37
@justlevine justlevine added Type: Enhancement New feature or request Status: In Review Needs to be reviewed by a project maintainer before merge scope: build scripts Affects build scripts, CI workflows, and automation. labels Jun 29, 2023
@jasonbahl jasonbahl merged commit 67f5b3f into wp-graphql:develop Jun 29, 2023
26 checks passed
@coveralls
Copy link

Coverage Status

coverage: 85.064%. remained the same when pulling a87c02f on justlevine:ci/phpstan-step-debug into 9f4eb31 on wp-graphql:develop.

@justlevine justlevine deleted the ci/phpstan-step-debug branch June 29, 2023 22:19
This was referenced Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: build scripts Affects build scripts, CI workflows, and automation. Status: In Review Needs to be reviewed by a project maintainer before merge Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants