Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Indent WP 6.2 in workflow file #2849

Merged
merged 1 commit into from Jul 10, 2023

Conversation

markkelnar
Copy link
Contributor

@markkelnar markkelnar commented Jul 10, 2023

What does this implement/fix? Explain your changes.

… The github image build for WP 6.2 are being excluded for all PHP versions instead of just one specific PHP version as intended. This is a simple fix and should build/deploy images on the next tag/release of this plugin.

Does this close any currently open issues?

closes #2848

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System:

WordPress Version:

@codeclimate
Copy link

codeclimate bot commented Jul 10, 2023

Code Climate has analyzed commit 1442bfe and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 🙌

image

@jasonbahl jasonbahl merged commit 655acad into wp-graphql:develop Jul 10, 2023
32 checks passed
@coveralls
Copy link

Coverage Status

coverage: 85.064%. remained the same when pulling 1442bfe on markkelnar:ci-wp-6.2 into b0d7813 on wp-graphql:develop.

@jasonbahl jasonbahl mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image ignored for WP 6.2
4 participants