fix: querying posts by slug or uri when the post name is non-ascii #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update the Post model to return the slug & link passed through urlencode
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -527,7 +527,7 @@ protected function init() { | |||
| return ! empty( $this->data->ping_status ) ? $this->data->ping_status : null; | |||
| }, | |||
| 'slug' => function () { | |||
| return ! empty( $this->data->post_name ) ? $this->data->post_name : null; | |||
| return ! empty( $this->data->post_name ) ? urldecode( $this->data->post_name ) : null; | |||
There was a problem hiding this comment.
Avoid too many return statements within this method.
| @@ -683,7 +683,7 @@ protected function init() { | |||
| $link = get_permalink( $this->data->ID ); | |||
| } | |||
|
|
|||
| return ! empty( $link ) ? $link : null; | |||
| return ! empty( $link ) ? urldecode( $link ) : null; | |||
There was a problem hiding this comment.
Avoid too many return statements within this method.
|
Code Climate has analyzed commit fa8d9cb and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
This was referenced Jul 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where querying posts by slug or uri was returning null when the post's name (slug) included non-ascii characters.
Failing Tests: https://github.com/wp-graphql/wp-graphql/actions/runs/5521919716/jobs/10070736088?pr=2851
Passing Tests: https://github.com/wp-graphql/wp-graphql/actions/runs/5522008949/jobs/10070950056?pr=2851
Does this close any currently open issues?
Any other comments?
I've created 2 posts with the following titles:
سلام-دنیا🍌This gives me posts visible at the following URLs:
/blog/2023/07/11/🍌//blog/2023/07/10/سلام-دنیا/Before:
Querying these posts by their slugs / uri would return null:
After:
Querying these posts by their slugs / uri returns the expected nodes: