fix: internal server error when query max depth setting is left empty #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add sanitization callback to the query_depth_max setting, ensuring that the saved value is a positive integer, else default to 10
jasonbahl
changed the title
|
Code Climate has analyzed commit 725df89 and detected 0 issues on this pull request. View more on Code Climate. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug that occurs when leaving the "Max Depth to allow for GraphQL Queries" value empty in the GraphQL > Settings page.
Does this close any currently open issues?
closes #2809
Any other comments?
If the value entered in the "Max Depth" setting is a non-positive integer, the default value of 10 will be saved. If a non-positive integer is already stored for the setting value, the default of 10 will be used.