fix: user roles should return empty

[j3ang]

What does this implement/fix? Explain your changes.

When my user does not have any roles assigned. wp-graphql is returning all existing roles instead of null or empty roles.
…

Does this close any currently open issues?

…

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

…

Where has this been tested?

Operating System: aws lightsail bitnami wordpress

WordPress Version: 6.2

[justlevine]

Thanks @j3ang !

It would probably be more performant if we bail before the ConnectionResolver, instead of forcing the resolver to run a query that we know will return null. Would you mind updating the resolver logic?

E.g.

if ( empty( $user->roles ) ) {
  return null;
}

$resolver = new UserRoleConnectionResolver( $user, $args, $context, $info );
$resolver->set_query_arg( 'slugIn', $user->roles );

return $resolver->get_connection();

[jasonbahl]

@j3ang would you be willing to write a test for this to ensure we don't have regressions on this in the future?

Something similar to the tests here: https://github.com/wp-graphql/wp-graphql/blob/develop/tests/wpunit/UserRoleConnectionQueriesTest.php

we'd want a test that:

• Creates a user with no rule
• Executes the query you reported this issue with
• Asserts that no roles are returned for that user

The test should fail on current latest WPGraphQL and pass with your change in place.

[codeclimate]

Code Climate has analyzed commit 57ecab5 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

[jasonbahl]

@j3ang thanks for adding the test 🙌🏻

[jasonbahl]

I made some modifications locally, but Git isn't letting me push to your branch, so I will merge this and follow-up with the changes