fix: default excerptRendered to empty string
#2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
changed the title
excerptRendered to empty string
justlevine
added
Type: Bug
jasonbahl
reviewed
Aug 14, 2023
jasonbahl
approved these changes
Aug 14, 2023
|
Code Climate has analyzed commit c343f25 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving This error/pull
Error: Deprecated:
trim():Passing null to parameter #1($string)of type string is deprecatedGoal: To return empty string if no excerpt, (instead of just null)
Additional info
#2896 (comment)
Where has this been tested?
Plugin Version: 1.14.10
WordPress Version: 6.3