Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement PHPCS sniffs from Slevomat Coding Standards #2900

Merged
merged 12 commits into from Aug 14, 2023

Conversation

justlevine
Copy link
Collaborator

What does this implement/fix? Explain your changes.

Implements a plethora of Slevomat Coding Standard sniffs into our PHPCS ruleset, and fixes the addressed smells.

Commits have been grouped by rule type for people curious, but feel free to squash-merge this.

Based off of #2899 (and requires that to be merged first).

Does this close any currently open issues?

cherry-picked from #2830

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

Where has this been tested?

Operating System:

WordPress Version:

@codeclimate
Copy link

codeclimate bot commented Aug 14, 2023

Code Climate has analyzed commit a12b0e9 and detected 0 issues on this pull request.

View more on Code Climate.

@jasonbahl jasonbahl merged commit 1a8933c into wp-graphql:develop Aug 14, 2023
24 checks passed
@coveralls
Copy link

coveralls commented Aug 14, 2023

Coverage Status

coverage: 84.94% (-0.04%) from 84.981% when pulling a12b0e9 on justlevine:chore/phpcs-slevomat into 52cc857 on wp-graphql:develop.

@justlevine justlevine deleted the chore/phpcs-slevomat branch August 14, 2023 21:35
@jasonbahl jasonbahl mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants