chore: handle unused variables (phpcs) #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherrypicked from wp-graphql#2830 Co-authored-by: Jason Bahl <jasonbahl@mac.com>
Cherrypicked from wp-graphql#2830 Co-authored-by: Jason Bahl <jasonbahl@mac.com>
Cherrypicked from wp-graphql#2830 Co-authored-by: Jason Bahl <jasonbahl@mac.com>
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -110,28 +110,28 @@ protected function init() { | |||
| return ! empty( $this->data->public ) ? (bool) $this->data->public : true; | |||
| }, | |||
| 'hierarchical' => function () { | |||
| return ( true === $this->data->hierarchical ) ? true : false; | |||
| return true === $this->data->hierarchical; | |||
There was a problem hiding this comment.
Avoid too many return statements within this method.
| }, | ||
| 'showUi' => function () { | ||
| return ( true === $this->data->show_ui ) ? true : false; | ||
| return true === $this->data->show_ui; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| }, | ||
| 'showInMenu' => function () { | ||
| return ( true === $this->data->show_in_menu ) ? true : false; | ||
| return true === $this->data->show_in_menu; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| }, | ||
| 'showInNavMenus' => function () { | ||
| return ( true === $this->data->show_in_nav_menus ) ? true : false; | ||
| return true === $this->data->show_in_nav_menus; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| }, | ||
| 'showCloud' => function () { | ||
| return ( true === $this->data->show_tagcloud ) ? true : false; | ||
| return true === $this->data->show_tagcloud; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
|
Code Climate has analyzed commit 3bf8f33 and detected 23 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jasonbahl
previously approved these changes
Aug 15, 2023
justlevine
dismissed
jasonbahl’s stale review
The merge-base changed after approval.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR adds the
SlevomatCodingStandard.Variables.UnusedVariablesniff to our PHPCS ruleset and remediates any unused variables in our codebase.The individual smells that required @jasonbahl 's expertise in #2830 were committed individually to expose those changes, especially 69854f6 which reads like a bugfix.
Based off of #2901 (and requires that to be merged first).
Does this close any currently open issues?
Cherrypicked from #2830
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
…
Where has this been tested?
Operating System: …
WordPress Version: …