fix: zip artifact in GH not in subfolder #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkelnar
changed the title
jasonbahl
requested changes
Aug 31, 2023
jasonbahl
reviewed
Aug 31, 2023
|
Code Climate has analyzed commit 6117004 and detected 0 issues on this pull request. View more on Code Climate. |
jasonbahl
previously approved these changes
Sep 6, 2023
markkelnar
dismissed
jasonbahl’s stale review
The merge-base changed after approval.
jasonbahl
approved these changes
Sep 6, 2023
jasonbahl
approved these changes
Sep 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
…The downloadable zip files in the 'assets' for a release page in GitHub, do not use a subfolder folder as the plugin downloaded from wordpress.org does.
The rsync in this PR is similar to how the 10up WordPress deploy works. 10up/action-wordpress-plugin-deploy
Add this as a composer command to be useable locally.
Similar to wp-graphql-smart-cache fix.
Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
…
Where has this been tested?
Operating System: …
WordPress Version: …