chore: upgrade WPCS to v3.0 #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
commented
Sep 6, 2023
justlevine
added a commit
to AxeWP/WPGraphQL-Coding-Standards
that referenced
this pull request
Sep 6, 2023
justlevine
commented
Sep 7, 2023
|
|
||
| <!-- This would be a breaking change to fix--> | ||
| <exclude name="WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid" /> | ||
|
|
||
| <!-- Should probably not be added back --> | ||
| <exclude name="PHPCompatibility.Keywords.ForbiddenNamesAsDeclared.objectFound"/> |
There was a problem hiding this comment.
This was replaced with Universal.NamingConventions.NoReservedKeywordParameterNames.objectFound and remediated in 66cc23c
|
Code Climate has analyzed commit ec93a97 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Commit ec93a97 escapes It's likely that we're "over-escaping" (many but not all
|
justlevine
added
Status: In Review
jasonbahl
approved these changes
Sep 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR updates WPCS and VIPCS to their latest v3.0 versions.
The individual remediation steps are in the commit history.
Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
See the diff comments.
Where has this been tested?
Operating System: Ubuntu 22.04 (wsl2 + devilbox + php 8.1.14)
WordPress Version: 6.3.1