Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup PHPCS inline annotations #2932

Merged
merged 4 commits into from Sep 18, 2023

Conversation

justlevine
Copy link
Collaborator

@justlevine justlevine commented Sep 16, 2023

What does this implement/fix? Explain your changes.

This PR:

  • Bumps wpcs to v3.0.1
  • Audits all phpcs annotations and removes those that are no longer necessary.
  • Replaces the use of generalized phpcs:disable and phpcs:ignore with the specific rule that is intended to be ignored, and fixes previously obfuscated smells.
  • Removes trailing whitespace from the end of lines (not a sniff in our current ruleset, just a pet peeve).

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

** No actual code has been changed **

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + PHP 8.1.14

WordPress Version: n/a

@codeclimate
Copy link

codeclimate bot commented Sep 16, 2023

Code Climate has analyzed commit b1d85e8 and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine added Status: In Review Needs to be reviewed by a project maintainer before merge Type: Chore (updating CI tasks etc; no production code change) scope: code quality Affects codebase complexity and maintainability labels Sep 16, 2023
@coveralls
Copy link

Coverage Status

coverage: 84.558%. remained the same when pulling b1d85e8 on justlevine:chore/cleanup-cs-annotations into 4050581 on wp-graphql:develop.

@jasonbahl jasonbahl merged commit f039972 into wp-graphql:develop Sep 18, 2023
28 checks passed
@justlevine justlevine deleted the chore/cleanup-cs-annotations branch September 18, 2023 20:12
@jasonbahl jasonbahl mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code quality Affects codebase complexity and maintainability Status: In Review Needs to be reviewed by a project maintainer before merge Type: Chore (updating CI tasks etc; no production code change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants