fix: correctly get default user role for settings selectbox
#2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Viktor Szepe <viktor@szepe.net>
justlevine
added
Type: Bug
jasonbahl
added
the
Needs: Tests
|
We should add a test for this |
|
@jasonbahl confession time: I never got the acceptance/functional suite working locally bc of the hardcoded I can find some time next week to sit down and finally configure it all and write this test, but if you (or anyone else) wants to beat me to it, commits are open on the branch 🤞 |
|
haha! All good. I can try and work on a test as well. |
…ts for the user role selects are loaded with the default values
|
Code Climate has analyzed commit da55fa1 and detected 0 issues on this pull request. View more on Code Climate. |
|
@justlevine I added a basic test. It tests the current implementation of the Settings API on the WPGraphQL Settings page, asserting that the 2 fields that use the user_role select load with the default value when the page is rendered. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR fixes
SettingsRegistry::callback_user_role_select()to correctly check$args['default']for the default role to use.Cherrypicked from @szepeviktor 's work in #2947
Does this close any currently open issues?
Supercedes #2497
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
…
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + PHP 8.1.15 )
WordPress Version: 6.3.1