chore: lint and remove useless variables [phpcs] #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
added
Status: In Review
|
Code Climate has analyzed commit 500825d and detected 0 issues on this pull request. View more on Code Climate. |
|
Those missing coverage lines weren't changed in this PR and dont currently appear in |
justlevine
added
the
Needs: Reviewer Response
jasonbahl
approved these changes
Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR adds the (auto-fixable)
SlevomatCodingStandard.Variables.UselessVariablesniff to our PHPCS ruleset, and remediates the handful of smells in our codebase.While useless variables aren't inherently a bad thing, the standardization will make code refractoring easier (since it'l be easier to spot duplicate code), and the fact that its auto-fixable means that there's no additional load for project maintainers.
Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
…
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.15)
WordPress Version: 6.3.2