fix: add polyfills for str_starts_with() and str_ends_with() to prevent fatal errors in PHP < 8.0
#2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polyfills added for `str_starts_with` and `str_ends_with`.
justlevine
added
Type: Bug
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * @param string $haystack | ||
| * @param string $needle | ||
| */ | ||
| function str_ends_with( string $haystack, string $needle ): bool { |
There was a problem hiding this comment.
Function str_ends_with has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 5d94410 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
justlevine
changed the title
str_starts_with() and str_ends_with() to prevent fatal errors in PHP < 8.0
3 tasks
jasonbahl
approved these changes
Nov 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Adds PHP 8.0 polyfills for
str_starts_with()andstr_ends_with().We're only using
str_ends_with()locally, the former is added preemptively since if a dev sees one, theyre going to assume they dont see the other.Does this close any currently open issues?
Fixes #2991
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
It's not getting picked up by PHPCompatibilityWP because our other dev-deps install symfony's polyfill package, so even on <8.0 the method exists on all dev environments.
Where has this been tested?
Operating System: Ubuntu 20.04 (Wsl2 + devilbox + php 8.1.15)
WordPress Version: 6.4.1