Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated AbstractConnectionResolver::setQueryArg() call with ::set_query_arg() #3006

Merged

Conversation

justlevine
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This PR replaces the deprecated call to AbstractConnectionResolver::setQueryArg() in ContentType.connectedTaxonomies resolver with AbstractConnectionResolver::set_query_arg().

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.1.15)

WordPress Version: 6.4.2

Copy link

codeclimate bot commented Dec 30, 2023

Code Climate has analyzed commit a3510a4 and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine added Type: Bug Something isn't working Status: In Review Needs to be reviewed by a project maintainer before merge scope: code quality Affects codebase complexity and maintainability labels Dec 30, 2023
@coveralls
Copy link

Coverage Status

coverage: 84.792%. remained the same
when pulling a3510a4 on justlevine:fix/replace-deprecated-setQueryArg
into 683352d on wp-graphql:develop.

@justlevine justlevine changed the title fix: replace deprecated setQueryArg() with set_query_arg() fix: replace deprecated AbstractConnectionResolver::setQueryArg() call with ::set_query_arg() Jan 10, 2024
@justlevine
Copy link
Collaborator Author

@jasonbahl can you review this when you get a minute?

@jasonbahl jasonbahl merged commit fa56cf1 into wp-graphql:develop Jan 23, 2024
28 of 29 checks passed
@justlevine justlevine deleted the fix/replace-deprecated-setQueryArg branch January 23, 2024 02:21
This was referenced Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code quality Affects codebase complexity and maintainability Status: In Review Needs to be reviewed by a project maintainer before merge Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants