fix: return empty when filtering menuItems by a location with no assigned items

[justlevine]

What does this implement/fix? Explain your changes.

This PR fixes an issue in the MenuItemConnectionResolver logic, where querying a menuItem by a location with unset terms would return all menu items, instead of none.

Logic has been changed so the tax_query args are given a 'term_id' => [].

Tests have been added to cover:

• A location with no menu items returns null.
• A location with no menu items returns null as an admin.
• A location with menu items, doesn't return items from a different location (either public or as an admin).

Does this close any currently open issues?

Fixes #3029

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

…

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.14)

WordPress Version: 6.4.3

[codeclimate]

Code Climate has analyzed commit 670b1bf and detected 0 issues on this pull request.

View more on Code Climate.

[coveralls]

coverage: 84.275%. remained the same
when pulling 670b1bf on justlevine:fix/menu-items-location-filter
into afe6a52 on wp-graphql:develop.

[jasonbahl]

@justlevine I pulled this branch and querying for a list of menuItems when no menu has been assigned to a location still returns random menu items 🤔

[jasonbahl]

@justlevine ah my bad. I was executing as an authenticated user who should see all menu items because they're not considered private. 🤦🏻‍♂️

[justlevine]

@justlevine ah my bad. I was executing as an authenticated user who should see all menu items because they're not considered private. 🤦🏻‍♂️

If my fix worked correctly then even if the user is authenticated they should only receive the items they're actually filtering for, so it should still come back []. 🤔

[jasonbahl]

ok, ya, authenticated users still get the incorrect behavior then.

[jasonbahl]

@justlevine let me confirm that I didn't have anything else going on. . .like WPGraphQL Smart Cache object cache active or anything 👀

[jasonbahl]

@justlevine oooh. . .so this was related to WPGraphQL Smart Cache, but not really related to caching. . .

WPGraphQL Smart Cache declares WPGraphQL as a dev dependency and my local copy of WPGraphQL Smart Cache was overriding the checked out version of WPGraphQL I was testing 🤔

Interesting.

My hunch is that we don't actually need WPGraphQL defined as a dev dependency for WPGraphQL Smart Cache. That's wild though that the dev dependency was taking precedent over the actual active WPGraphQL plugin 🤔

Anyway, by de-activating WPGraphQL Smart Cache I was able to experience the intended behavior of no nodes resolving when filtering menus by location when that location has no menu assigned yet (even for admin user)