feat: add graphql_pre_resolve_menu_item_connected_node filter
#3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -180,14 +201,19 @@ public static function register_type() { | |||
| * | |||
| * @since 0.0.30 | |||
| */ | |||
| return apply_filters( | |||
| return apply_filters_deprecated( | |||
There was a problem hiding this comment.
Avoid too many return statements within this method.
|
Code Climate has analyzed commit e65fbc8 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
justlevine
added
Type: Enhancement
jasonbahl
approved these changes
Feb 14, 2024
justlevine
deleted the
dev/graphql_pre_resolve_menu_item_connected_node
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR adds the
graphql_pre_resolve_menu_item_connected_nodefilter to theMenuItem.connectedNoderesolver, allowing one to short-circuit the resolver logic and use a customAbstractConnectionResolver->get_connection()as the result.Additionally, the
graphql_resolve_menu_itemfilter on the deprecatedMenuItem.connectedObjectresolver has beendeprecated.This change brings parity between
connectedNodeandconnectedObject, and will allow developers still relying on the latter to finally migrate.Tests have been added both to cover the new filter, and to cover resolving
TermObjects (since that was missing).Does this close any currently open issues?
Fixes #2484
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
@todotag that will need to be replaced on release and will need to be replaced manually (its not in the usual@since @todoformat.Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.1.14)
WordPress Version: 6.4.3